Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Link docs from Headlamp instead of having a copy of them #32

Merged
merged 1 commit into from
Aug 7, 2024
Merged

docs: Link docs from Headlamp instead of having a copy of them #32

merged 1 commit into from
Aug 7, 2024

Conversation

joaquimrocha
Copy link
Collaborator

Use docs linked from the Headlamp repo. Needs the PR headlamp-k8s/headlamp#2208 .

@joaquimrocha joaquimrocha marked this pull request as draft July 27, 2024 00:32
@joaquimrocha joaquimrocha requested a review from sniok July 27, 2024 00:33
sniok
sniok approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@joaquimrocha joaquimrocha marked this pull request as ready for review August 7, 2024 10:26
@joaquimrocha joaquimrocha merged commit cc0b8a9 into main Aug 7, 2024
2 of 3 checks passed
@joaquimrocha joaquimrocha deleted the link-docs branch August 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniok sniok sniok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaquimrocha @sniok